Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl, executor: executor change for pause/resume on ddl jobs #43171

Merged
merged 8 commits into from
May 9, 2023
Merged

ddl, executor: executor change for pause/resume on ddl jobs #43171

merged 8 commits into from
May 9, 2023

Conversation

dhysum
Copy link
Contributor

@dhysum dhysum commented Apr 19, 2023 •
edited
Loading

Add Pause/Resume admin command in parser and planner

What problem does this PR solve?
Issue Number: close #18015 #40041

Related issue number: #39751 #43061

Related PR: #43081

Problem Summary: Add pause/resume on ddl jobs

What is changed and how it works?

Add admin pause ddl jobs 3,5;
a. the job should be in Running or Queueing state
b. change the state to be Pausing on command issued, in another PR
c. background work will pause the job once scheduled, in another PR

Add admin resume ddl jobs 3,5;
a. the job should be paused
b. change the state to be Queueing on command issued, in another PR
c. background worker will continue the job, no need to change

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 19, 2023 •
edited by ti-chi-bot bot
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Benjamin2037
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Apr 19, 2023
@ti-chi-bot
Copy link
Member

Hi @dhysum. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Benjamin2037
Benjamin2037 reviewed Apr 19, 2023
View reviewed changes
errno/errcode.go Outdated Show resolved Hide resolved
@dhysum dhysum force-pushed the dev/job_pause_resume_executor branch from 0a6ea57 to 895b561 Compare April 19, 2023 02:46
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 19, 2023
@dhysum dhysum force-pushed the dev/job_pause_resume_executor branch from 895b561 to 298152b Compare April 19, 2023 02:53
zimulala
zimulala reviewed Apr 19, 2023
View reviewed changes
ddl/ddl.go Show resolved Hide resolved
Benjamin2037
Benjamin2037 reviewed Apr 19, 2023
View reviewed changes
parser/model/ddl.go Outdated Show resolved Hide resolved
@dhysum dhysum force-pushed the dev/job_pause_resume_executor branch 5 times, most recently from 82f8e48 to 8ec148f Compare April 20, 2023 01:08
@Benjamin2037 Benjamin2037 mentioned this pull request Apr 20, 2023
Closed
5 tasks
Benjamin2037
Benjamin2037 reviewed Apr 21, 2023
View reviewed changes
errno/errcode.go Outdated Show resolved Hide resolved
@dhysum dhysum force-pushed the dev/job_pause_resume_executor branch 2 times, most recently from bbbab72 to b2c3473 Compare April 23, 2023 02:42
Benjamin2037
Benjamin2037 reviewed Apr 24, 2023
View reviewed changes
ddl/ddl.go Outdated Show resolved Hide resolved
Benjamin2037
Benjamin2037 reviewed Apr 24, 2023
View reviewed changes
ddl/ddl.go Outdated Show resolved Hide resolved
Benjamin2037
Benjamin2037 reviewed Apr 24, 2023
View reviewed changes
parser/model/ddl.go Outdated Show resolved Hide resolved
Benjamin2037
Benjamin2037 reviewed Apr 24, 2023
View reviewed changes
parser/model/ddl.go Outdated Show resolved Hide resolved
@dhysum dhysum force-pushed the dev/job_pause_resume_executor branch from b2c3473 to 0be1549 Compare April 25, 2023 08:08
@dhysum
Copy link
Contributor Author

dhysum commented May 9, 2023

/retest

1 similar comment
@dhysum
Copy link
Contributor Author

dhysum commented May 9, 2023

/retest

@dhysum
Copy link
Contributor Author

dhysum commented May 9, 2023

/retest-required

@dhysum
Copy link
Contributor Author

dhysum commented May 9, 2023

/retest

1 similar comment
@zimulala
Copy link
Contributor

zimulala commented May 9, 2023

/retest

@dhysum
Copy link
Contributor Author

dhysum commented May 9, 2023

/retest

@dhysum
Copy link
Contributor Author

dhysum commented May 9, 2023

/retest-required

@zimulala
Copy link
Contributor

zimulala commented May 9, 2023

/status/can-merge

@zimulala zimulala added the status/can-merge Indicates a PR has been approved by a committer. label May 9, 2023
@ti-chi-bot ti-chi-bot bot removed the status/can-merge Indicates a PR has been approved by a committer. label May 9, 2023
@dhysum
Copy link
Contributor Author

dhysum commented May 9, 2023

/retest

@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 9, 2023

This pull request has been accepted and is ready to merge.

Commit hash: f3f8d00

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 9, 2023
@hawkingrei
Copy link
Member

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2023
@hawkingrei
Copy link
Member

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2023
@ti-chi-bot ti-chi-bot bot merged commit 0d3ad53 into pingcap:master May 9, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request May 9, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #43658.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 9, 2023
@dhysum @ti-chi-bot
This is an automated cherry-pick of pingcap#43171
f842b72 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
dhysum added a commit to dhysum/tidb that referenced this pull request May 10, 2023
@dhysum
ddl, executor: executor change for pause/resume on ddl jobs (pingcap#…
9804b80 
…43171)

close pingcap#18015, ref pingcap#40041
@dhysum dhysum mentioned this pull request May 10, 2023
Merged
12 tasks
dhysum added a commit to dhysum/tidb that referenced this pull request May 11, 2023
@dhysum
ddl, executor: executor change for pause/resume on ddl jobs (pingcap#…
8565dbe 
…43171)

close pingcap#18015, ref pingcap#40041
@zimulala zimulala mentioned this pull request May 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta left review comments

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@zimulala zimulala zimulala approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pause add an index(write reorganization) and set a time window to resume
6 participants
@dhysum @ti-chi-bot @Benjamin2037 @zimulala @hawkingrei @tangenta