planner, stats: assign high priority for sync load related internal SQLs #51636
Conversation
ti-chi-bot
bot
added
release-note-none
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #51636 +/- ##
=================================================
- Coverage 72.5737% 56.4018% -16.1719%
=================================================
Files 1506 1627 +121
Lines 431247 610358 +179111
=================================================
+ Hits 312972 344253 +31281
- Misses 98987 242825 +143838
- Partials 19288 23280 +3992
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ti-chi-bot
bot
added
the
needs-rebase
winoros
force-pushed
the
syncload-high-pri
branch
from
be96c8f to
6b71abb
Compare
ti-chi-bot
bot
added
size/XS
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
winoros
force-pushed
the
syncload-high-pri
branch
from
6b71abb to
7b24b8a
Compare
ti-chi-bot
bot
added
sig/planner
|
@hawkingrei: Your lgtm message is repeated, so it is ignored. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ti-chi-bot
bot
added
size/L
| // HistogramFromStorage reads histogram from storage. | ||
| func HistogramFromStorage(sctx sessionctx.Context, tableID int64, colID int64, tp *types.FieldType, distinct int64, isIndex int, ver uint64, nullCount int64, totColSize int64, corr float64) (_ *statistics.Histogram, err error) { | ||
| rows, fields, err := util.ExecRows(sctx, "select count, repeats, lower_bound, upper_bound, ndv from mysql.stats_buckets where table_id = %? and is_index = %? and hist_id = %? order by bucket_id", tableID, isIndex, colID) | ||
| func HistogramFromStorage( |
There was a problem hiding this comment.
We don't need this function anymore. We can merge these two functions.
ti-chi-bot
bot
added
size/M
[LGTM Timeline notifier]Timeline:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, time-and-fate, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@winoros: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cherrypick release-8.1 |
|
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/cherrypick release-7.5 |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: ref #50332, and is the patch after #50343
Problem Summary:
What changed and how does it work?
The original pr didn't solve the problem. I continue the work based on it.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.