Skip to content

Data channel: Add Close and OnClose #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 23, 2019
Merged

Data channel: Add Close and OnClose #355

merged 4 commits into from
Jan 23, 2019

Conversation

@backkem
Copy link
Member

@backkem backkem commented Jan 12, 2019 •
edited
Loading

Relates to #180
Resolves #329

TODO:

@backkem backkem added the review label Jan 12, 2019
@coveralls
Copy link

coveralls commented Jan 12, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1868

  • 46 of 80 (57.5%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 77.16%
Changes Missing Coverage Covered Lines Changed/Added Lines %
rtcpeerconnection.go 4 7 57.14%
internal/mux/mux.go 14 18 77.78%
rtcdatachannel.go 28 55 50.91%
Files with Coverage Reduction New Missed Lines %
rtcpeerconnection.go 2 76.51%
Totals Coverage Status
Change from base Build 1862: 0.2%
Covered Lines: 5162
Relevant Lines: 6690
💛 - Coveralls

@backkem backkem force-pushed the datachannel-close branch 2 times, most recently from 2ac5718 to 911d6ec Compare January 15, 2019 10:05
@backkem backkem requested a review from Sean-Der January 15, 2019 10:14
@backkem backkem force-pushed the datachannel-close branch 2 times, most recently from b92f71e to 3d853a3 Compare January 16, 2019 18:51
@backkem backkem changed the title Data channel: Add Close and OnClose [WIP] Data channel: Add Close and OnClose Jan 18, 2019
@backkem backkem removed the request for review from Sean-Der January 18, 2019 22:59
Sean-Der
Sean-Der approved these changes Jan 21, 2019
View reviewed changes
Copy link
Member

@Sean-Der Sean-Der left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @backkem I am good with this being merged. Would love to see your work get in (and not start to conflict)

We need to do CI though, and add tooling so it doesn't regress (I will do that) will start right after I finish ORTC media. Almost done just kicking out PRs now.

@backkem backkem force-pushed the datachannel-close branch 2 times, most recently from 94cb29b to a012eaa Compare January 23, 2019 15:33
@backkem
Mux: Don't lock during dispatch
6ca3270 
Changes the mux dispatch logic to hold the mux lock less long.
@backkem backkem changed the title [WIP] Data channel: Add Close and OnClose Data channel: Add Close and OnClose Jan 23, 2019
Sean-Der
Sean-Der reviewed Jan 23, 2019
View reviewed changes
@backkem
DataChannel: warn on short read
6194bc1 
Resolves #365
@backkem
Cleanup dependencies
4ac61df 
Make a separate module for the quic package to bundle all quic
dependencies and cleanup the root mod file.
@backkem backkem merged commit 4074744 into master Jan 23, 2019
@backkem backkem deleted the datachannel-close branch January 23, 2019 22:17
@backkem backkem removed the review label Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sean-Der Sean-Der Sean-Der approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@backkem @coveralls @Sean-Der