Fix deadlock in DTLS shutdown #488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should have a fix soon, but wanted to make sure I had reproduce first |
Sean-Der
commented
Mar 7, 2019
| time.Sleep(3 * time.Second) // TODO PeerConnection.Close() doesn't block for all subsystems | ||
| close(iceComplete) | ||
| }() | ||
| time.Sleep(3 * time.Second) // TODO PeerConnection.Close() doesn't block for all subsystems |
There was a problem hiding this comment.
This is fired in a goroutine already, I don't want users to see this and assume they need the same.
Sean-Der
commented
Mar 7, 2019
|
|
||
| if endpoint == nil { | ||
| fmt.Printf("Warning: mux: no endpoint for packet starting with %d\n", buf[0]) | ||
| muxLog.Warnf("Warning: mux: no endpoint for packet starting with %d\n", buf[0]) |
There was a problem hiding this comment.
Just moving everything off of fmt.
Pull Request Test Coverage Report for Build 2377
💛 - Coveralls |
DTLS shutdown deadlocks if Close is called before startup completes, because the DTLS connection hasn't finished yet we don't have handles to close anything. This updates DTLS to follow how SCTP is shutdown, by shutting down the nextConn (ICE in this case) we can shutdown the subsystem. By closing ICE first, DTLS (and then SCTP) close properly no matter what state they are in. Resolves #487
Sean-Der
changed the title
backkem
approved these changes
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DTLS shutdown deadlocks if Close is called before startup completes,
because the DTLS connection hasn't finished yet we don't have handles
to close anything.
This updates DTLS to follow how SCTP is shutdown, by shutting down the
nextConn (ICE in this case) we can shutdown the subsystem. By closing
ICE first, DTLS (and then SCTP) close properly no matter what state
they are in.