Skip to content

Conversation

@enobufs
Copy link
Member

@enobufs enobufs commented Mar 18, 2019

As discussed in slack, all DataChannel public props are converted to methods to avoid race conditions.

Resolves #505

@enobufs enobufs added the review label Mar 18, 2019
@enobufs enobufs requested review from albrow and backkem March 18, 2019 23:42
@enobufs enobufs self-assigned this Mar 18, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2544

  • 100 of 103 (97.09%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 81.117%

Changes Missing Coverage Covered Lines Changed/Added Lines %
datachannel.go 93 96 96.88%
Files with Coverage Reduction New Missed Lines %
datachannel.go 1 76.61%
Totals Coverage Status
Change from base Build 2539: 0.4%
Covered Lines: 4184
Relevant Lines: 5158

💛 - Coveralls

@enobufs enobufs merged commit 8bd831f into master Mar 19, 2019
@enobufs enobufs removed the review label Mar 19, 2019
@enobufs enobufs deleted the issue-505 branch March 19, 2019 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants