Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce IssueToken action query #2526

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Introduce IssueToken action query #2526

merged 2 commits into from
Aug 5, 2024

Conversation

ipdae
Copy link
Member

@ipdae ipdae commented Aug 5, 2024

@ipdae ipdae requested review from U-lis and moreal August 5, 2024 08:52
@auto-assign auto-assign bot requested a review from area363 August 5, 2024 08:52
@ipdae ipdae self-assigned this Aug 5, 2024
@ipdae ipdae force-pushed the feature/issue-2523 branch from 094aca5 to 946a618 Compare August 5, 2024 08:53
@ipdae ipdae added this to the 180 milestone Aug 5, 2024
@ipdae @moreal
Apply suggestions from code review
89d9a5a 
Co-authored-by: Lee Dogeon <dev.moreal@gmail.com>
moreal
moreal approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@moreal moreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because logic code can be modified after, I approved but it is also good to fix the variable name in this pull request.

NineChronicles.Headless/GraphTypes/ActionQueryFields/IssueToken.cs
resolve: context =>
{
var fungibleAssetValues = context.GetArgument<List<FungibleAssetValue>>("fungibleAssetValues");
var items = context.GetArgument<List<(int ItemIdAndCountInputType, int count)>>("items");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var items = context.GetArgument<List<(int ItemIdAndCountInputType, int count)>>("items");
var items = context.GetArgument<List<(int itemId, int count)>>("items");

@ipdae ipdae merged commit 3f9ed40 into rc-180 Aug 5, 2024
16 checks passed
@moreal moreal mentioned this pull request Aug 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moreal moreal moreal approved these changes

@U-lis U-lis Awaiting requested review from U-lis

@area363 area363 Awaiting requested review from area363

Assignees

@ipdae ipdae

Labels
None yet
Projects
None yet
Milestone
180
Development

Successfully merging this pull request may close these issues.
2 participants
@ipdae @moreal