apply changes to Lib9c #2548
Merged
apply changes to Lib9c #2548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moreal
reviewed
Aug 26, 2024
NineChronicles.Headless/GraphTypes/ActionQueryFields/RapidCombination.cs
Outdated
Show resolved
Hide resolved
| { | ||
| Name = "slotIndex", | ||
| Description = "Slot index to execute rapid" | ||
| Name = "slotIndexList", |
There was a problem hiding this comment.
Also, since these changes are breaking-changes, you should check if there is anywhere that uses this query.
|
lint broken 😢 |
…re/change-rapid-combination-action-query
|
@U-lis I can't find lint broken point |
…ination.cs Co-authored-by: Lee Dogeon <dev.moreal@gmail.com>
|
Other parts of a similar type are applied in the form I used. I guess these parts are also not the form that should include null. |
sonohoshi
reviewed
Aug 29, 2024
NineChronicles.Headless/GraphTypes/ActionQueryFields/RapidCombination.cs
Show resolved
Hide resolved
sonohoshi
approved these changes
Aug 29, 2024
NineChronicles.Headless/GraphTypes/ActionQueryFields/RapidCombination.cs
Show resolved
Hide resolved
…re/change-rapid-combination-action-query # Conflicts: # NineChronicles.Headless.Tests/GraphTypes/ActionQueryTest.cs # NineChronicles.Headless/GraphTypes/ActionQueryFields/RapidCombination.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apply changes to Lib9c
planetarium/lib9c#2765