Preload blocks from multiple peers at a time #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlia
force-pushed
the
block-completion
branch
2 times, most recently
from
bd6ec9c
to
6210fe2
Compare
|
It seems builds fail. 😢 |
limebell
reviewed
Dec 9, 2019
dahlia
force-pushed
the
block-completion
branch
from
6210fe2
to
1011189
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
dahlia
force-pushed
the
block-completion
branch
5 times, most recently
from
3fd4ded
to
37cd5f1
Compare
Codecov Report
@@ Coverage Diff @@
## master #707 +/- ##
==========================================
+ Coverage 86.43% 86.65% +0.21%
==========================================
Files 226 231 +5
Lines 19496 20444 +948
==========================================
+ Hits 16852 17716 +864
- Misses 1432 1502 +70
- Partials 1212 1226 +14
|
dahlia
force-pushed
the
block-completion
branch
7 times, most recently
from
0598b60
to
bbff23c
Compare
dahlia
force-pushed
the
block-completion
branch
from
bbff23c
to
eabc62b
Compare
- Add delay to avoid timing issue - Loosen assertion - Loosen timeout - Adjust jitter
dahlia
force-pushed
the
block-completion
branch
from
7345445
to
b312195
Compare
earlbread
approved these changes
Feb 4, 2020
|
@planetarium/libplanet Rebased this on the current master. Please review this again! FYI only changelogs had been changed since then. |
limebell
approved these changes
Feb 4, 2020
moreal
approved these changes
Feb 4, 2020
limebell
added a commit
to limebell/libplanet
that referenced
this pull request
Feb 11, 2020
limebell
added a commit
that referenced
this pull request
Feb 11, 2020
Revert "Preload blocks from multiple peers at a time" (#707)
dahlia
added a commit
to dahlia/libplanet
that referenced
this pull request
Feb 11, 2020
This reverts commit eb1e5e7.
dahlia
added a commit
to dahlia/libplanet
that referenced
this pull request
Feb 14, 2020
This reverts commit eb1e5e7.
libplanet
pushed a commit
to dahlia/libplanet
that referenced
this pull request
Feb 22, 2020
This reverts commit eb1e5e7.
dahlia
added a commit
to dahlia/libplanet
that referenced
this pull request
Feb 24, 2020
This reverts commit eb1e5e7.
dahlia
added a commit
that referenced
this pull request
Feb 24, 2020
Restore BlockCompletion<T> (#707) and more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes IDL parallel by requesting chunks of blocks to multiple peers. As complexity of IDL logic grows up, I added a separated class named
BlockCompletion<T>which has only a pure logic of dealing with block demands and completion without actual I/Os, and madeSwarm<T>.PreloadAsync()method to use it.