Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poll blocks and txs #784

Merged
merged 10 commits into from
Feb 12, 2020
Merged

Conversation

limebell
Copy link
Member

@limebell limebell commented Feb 4, 2020

This patch makes swarm to poll blocks and transactions from other peers. I guess it can be replaced with #707 for the case of blocks.

Todo:

  • Add test cases
  • Add changelog

@limebell limebell added the network Related to networking (Libplanet.Net) label Feb 4, 2020
@limebell limebell requested a review from longfin February 4, 2020 11:52
@limebell limebell self-assigned this Feb 4, 2020
@limebell limebell force-pushed the experimental/smart-fillblock branch 2 times, most recently from b775272 to 8310091 Compare February 6, 2020 09:43
@limebell limebell changed the title [WIP] Poll blocks and txs Poll blocks and txs Feb 6, 2020
Libplanet/Net/Swarm.cs Show resolved Hide resolved
Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved
Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved
Libplanet/Net/Swarm.cs Show resolved Hide resolved
Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved
earlbread
earlbread previously approved these changes Feb 7, 2020
longfin
longfin previously approved these changes Feb 7, 2020
Libplanet.Tests/Net/SwarmTest.cs Outdated Show resolved Hide resolved
@limebell limebell dismissed stale reviews from longfin and earlbread via 5720447 February 7, 2020 12:58
@limebell limebell force-pushed the experimental/smart-fillblock branch 2 times, most recently from e09fd81 to 52ab6d9 Compare February 10, 2020 07:49
longfin
longfin previously approved these changes Feb 11, 2020
moreal
moreal previously approved these changes Feb 11, 2020
@limebell limebell dismissed stale reviews from moreal and longfin via eb12696 February 11, 2020 07:32
@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #784 into master will increase coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #784      +/-   ##
==========================================
+ Coverage   86.50%   86.65%   +0.14%     
==========================================
  Files         227      227              
  Lines       19619    19654      +35     
==========================================
+ Hits        16972    17031      +59     
+ Misses       1433     1414      -19     
+ Partials     1214     1209       -5     
Impacted Files Coverage Δ
Libplanet/Store/DefaultStore.cs 84.55% <0.00%> (-1.00%) ⬇️

moreal
moreal previously approved these changes Feb 11, 2020
earlbread
earlbread previously approved these changes Feb 11, 2020
CHANGES.md Outdated Show resolved Hide resolved
Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved
Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved
Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved
Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved
Libplanet/Net/NetMQTransport.cs Outdated Show resolved Hide resolved
Libplanet/Net/NetMQTransport.cs Outdated Show resolved Hide resolved
Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved
Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved
Libplanet/Net/NetMQTransport.cs Outdated Show resolved Hide resolved
@limebell limebell dismissed stale reviews from earlbread and moreal via a7730fe February 12, 2020 06:29
@longfin longfin merged commit 06186b6 into planetarium:master Feb 12, 2020
@dahlia dahlia mentioned this pull request May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
network Related to networking (Libplanet.Net)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants