Mine block without txs having lower nonce #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #791 +/- ##
==========================================
+ Coverage 86.64% 86.66% +0.02%
==========================================
Files 227 227
Lines 19654 19674 +20
==========================================
+ Hits 17029 17051 +22
Misses 1414 1414
+ Partials 1211 1209 -2
|
moreal
changed the title
moreal
force-pushed
the
bugfix/not-stage-txs-having-lower-nonce
branch
from
92e5314
to
59cdaed
Compare
moreal
changed the title
moreal
force-pushed
the
bugfix/not-stage-txs-having-lower-nonce
branch
from
59cdaed
to
74be4fd
Compare
moreal
changed the title
longfin
reviewed
Feb 11, 2020
moreal
force-pushed
the
bugfix/not-stage-txs-having-lower-nonce
branch
2 times, most recently
from
6a6f1f6
to
17c8965
Compare
longfin
previously approved these changes
Feb 11, 2020
earlbread
previously approved these changes
Feb 12, 2020
limebell
previously approved these changes
Feb 12, 2020
dahlia
reviewed
Feb 12, 2020
longfin
previously approved these changes
Feb 12, 2020
Co-Authored-By: Hong Minhee <hong.minhee@gmail.com>
moreal
force-pushed
the
bugfix/not-stage-txs-having-lower-nonce
branch
from
3611b57
to
60d3e23
Compare
longfin
approved these changes
Feb 12, 2020
earlbread
approved these changes
Feb 12, 2020
longfin
approved these changes
Feb 12, 2020
limebell
approved these changes
Feb 12, 2020
dahlia
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem that
BlockChain.MineBlock()method couldn't mine valid block when there was transactions having lower nonce than expected nonce. So, in this PR,BlockChain.MineBlock()method became to ignore the transactions and to mine.