IKeyStore & Web3KeyStore #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #831 +/- ##
========================================
Coverage 87.48% 87.48%
========================================
Files 244 249 +5
Lines 22294 22500 +206
========================================
+ Hits 19503 19684 +181
- Misses 1443 1471 +28
+ Partials 1348 1345 -3
|
longfin
reviewed
Mar 23, 2020
earlbread
reviewed
Mar 24, 2020
moreal
reviewed
Mar 24, 2020
longfin
previously approved these changes
Mar 24, 2020
moreal
previously approved these changes
Mar 24, 2020
longfin
approved these changes
Mar 24, 2020
|
@earlbread Removed unnecessary @planetarium/libplanet Sorry guys, I amended it again. Please review this again. |
earlbread
approved these changes
Mar 24, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch finally implements the complete Web3 Secret Storage.
I also experimented with C# 8's nullable reference types. We could gradually adopt it by enabling nullable context per file (instead of the whole project, i.e., #458).