Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IKeyStore & Web3KeyStore #831

Merged
merged 1 commit into from Mar 24, 2020
Merged

IKeyStore & Web3KeyStore #831

merged 1 commit into from Mar 24, 2020

Conversation

@dahlia
Copy link
Member

dahlia commented Mar 23, 2020

This patch finally implements the complete Web3 Secret Storage.

I also experimented with C# 8's nullable reference types. We could gradually adopt it by enabling nullable context per file (instead of the whole project, i.e., #458).

@dahlia dahlia requested review from longfin, earlbread and moreal Mar 23, 2020
@dahlia dahlia self-assigned this Mar 23, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #831 into master will increase coverage by 0.00%.
The diff coverage is 87.37%.

@@           Coverage Diff            @@
##           master     #831    +/-   ##
========================================
  Coverage   87.48%   87.48%            
========================================
  Files         244      249     +5     
  Lines       22294    22500   +206     
========================================
+ Hits        19503    19684   +181     
- Misses       1443     1471    +28     
+ Partials     1348     1345     -3     
Impacted Files Coverage Δ
Libplanet.Tests/KeyStore/Web3KeyStoreTest.cs 75.00% <75.00%> (ø)
Libplanet/KeyStore/NoKeyException.cs 80.00% <80.00%> (ø)
Libplanet/KeyStore/Web3KeyStore.cs 90.21% <90.21%> (ø)
Libplanet.Tests/KeyStore/KeyStoreTest.cs 94.44% <94.44%> (ø)
Libplanet/KeyStore/KeyStoreException.cs 100.00% <100.00%> (ø)
Libplanet/Net/Swarm.cs 84.86% <0.00%> (-0.40%) ⬇️
... and 4 more
Libplanet/KeyStore/Web3KeyStore.cs Show resolved Hide resolved
Libplanet/KeyStore/Web3KeyStore.cs Outdated Show resolved Hide resolved
Libplanet/KeyStore/Web3KeyStore.cs Show resolved Hide resolved
Libplanet/KeyStore/Web3KeyStore.cs Outdated Show resolved Hide resolved
Libplanet/KeyStore/IKeyStore.cs Outdated Show resolved Hide resolved
@dahlia dahlia force-pushed the dahlia:keystore branch from 6594839 to 8e0692a Mar 24, 2020
@dahlia dahlia requested review from longfin, moreal and earlbread Mar 24, 2020
@dahlia dahlia force-pushed the dahlia:keystore branch from 8e0692a to b171012 Mar 24, 2020
@dahlia dahlia dismissed stale reviews from moreal and longfin via 8093d12 Mar 24, 2020
@dahlia dahlia force-pushed the dahlia:keystore branch from b171012 to 8093d12 Mar 24, 2020
@dahlia dahlia requested review from moreal and longfin Mar 24, 2020
@dahlia

This comment has been minimized.

Copy link
Member Author

dahlia commented Mar 24, 2020

@earlbread Removed unnecessary #nullable restore directives.

@planetarium/libplanet Sorry guys, I amended it again. Please review this again.

@dahlia dahlia merged commit a2dc2f1 into planetarium:master Mar 24, 2020
14 of 15 checks passed
14 of 15 checks passed
codecov/patch 87.37% of diff hit (target 87.48%)
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/project 87.48% (+0.00%) compared to 3760cca
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20200324.3 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.