Add genesis hash to transaction #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longfin
requested review from
dahlia,
moreal,
longfin,
earlbread and
riemannulus
and removed request for
dahlia and
moreal
Codecov Report
@@ Coverage Diff @@
## master #878 +/- ##
==========================================
- Coverage 87.41% 87.24% -0.18%
==========================================
Files 250 247 -3
Lines 22739 22223 -516
==========================================
- Hits 19878 19388 -490
+ Misses 1529 1504 -25
+ Partials 1332 1331 -1
|
dahlia
approved these changes
May 25, 2020
longfin
approved these changes
May 25, 2020
earlbread
approved these changes
May 25, 2020
moreal
approved these changes
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds nullable genesis hash field to transaction, which resolves #796.