Eliminate double download of assets and orders #1010
Labels
Milestone
Comments
sgillies
added this to the
2.1.2: order download improvements: robust streaming and saved filename options milestone
sgillies
added a commit
that referenced
this issue
Aug 1, 2023
Wraps the entire orders.download_asset() in a retry, eliminating the double download and concentrating the retry complexity instead of spreading it over several modules. Resolves #1010
asonnenschein
modified the milestones:
2.1.2: order download improvements: robust streaming and saved filename options,
2.x.x: Major improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#1002 unintentionally introduces a double download. One at https://github.com/planetlabs/planet-client-python/pull/1002/files#diff-eb40861f30b566f7a4a569eb3e052b9edccf30400cbe3a309c34f914aab79cd1R600 and one at https://github.com/planetlabs/planet-client-python/pull/1002/files#diff-eb40861f30b566f7a4a569eb3e052b9edccf30400cbe3a309c34f914aab79cd1R620. The implementation of #1002 only requires the first to be an initial connection to get the Content-length header. We may want to change the implementation, but changing the
gettostreamis a good enough fix for the moment.The text was updated successfully, but these errors were encountered: