Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate double download of assets and orders #1010

Open
sgillies opened this issue Jul 31, 2023 · 0 comments
Open

Eliminate double download of assets and orders #1010

sgillies opened this issue Jul 31, 2023 · 0 comments
Labels
bug data api orders api sdk-2023.7
Milestone
2.1.2: order down...

Comments

@sgillies
Copy link
Contributor

sgillies commented Jul 31, 2023 •
edited

#1002 unintentionally introduces a double download. One at https://github.com/planetlabs/planet-client-python/pull/1002/files#diff-eb40861f30b566f7a4a569eb3e052b9edccf30400cbe3a309c34f914aab79cd1R600 and one at https://github.com/planetlabs/planet-client-python/pull/1002/files#diff-eb40861f30b566f7a4a569eb3e052b9edccf30400cbe3a309c34f914aab79cd1R620. The implementation of #1002 only requires the first to be an initial connection to get the Content-length header. We may want to change the implementation, but changing the get to stream is a good enough fix for the moment.
sgillies added a commit that referenced this issue Aug 1, 2023
@sgillies
New take on retrying order asset downloads
1950393 
Wraps the entire orders.download_asset() in a retry, eliminating
the double download and concentrating the retry complexity instead
of spreading it over several modules.

Resolves #1010
@sgillies sgillies mentioned this issue Aug 1, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug data api orders api sdk-2023.7
Projects
None yet
Milestone
2.1.2: order download improvements: r...
Development

No branches or pull requests
1 participant
@sgillies