Skip to content

add "create configuration" support for SH hosting in orders and subs #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

charcey
Copy link
Contributor

@charcey charcey commented Jan 28, 2025

Related Issue(s):

Closes #

Proposed Changes:

For inclusion in changelog (if applicable):

  1. create_configuration for Sentinel Hub hosting supported in Orders and Subscriptions Python SDK
  2. --create-configuration for Sentinel Hub hosting supported in Orders and Subscriptions CLI

Not intended for changelog:

Diff of User Interface

Old behavior:

New behavior:

  • Extra optional parameter of create_configuration in:
    • planet.subscription_request -> build_request
    • planet.order_request -> build_request
  • Extra optional option of --create-configuration in:
    • planet orders request
    • planet orders create
    • planet subscriptions request
    • planet subscriptions create

Note: create configuration and collection id are mutually exclusive but I have chosen to clean on the API to validate and not do that client side. So a request can be built successfully that will fail when submitted to the API.

PR Checklist:

  • This PR is as small and focused as possible
  • If this PR includes proposed changes for inclusion in the changelog, the title of this PR summarizes those changes and is ready for inclusion in the Changelog.
  • I have updated docstrings for function changes and docs in the 'docs' folder for user interface / behavior changes
  • This PR does not break any examples or I have updated them

(Optional) @mentions for Notifications:
@pl-gideon

@charcey charcey changed the title WIP: add create_configuraiton support for SH hosting in orders and subs WIP: add create_configuration support for SH hosting in orders and subs Jan 28, 2025
@charcey charcey changed the title WIP: add create_configuration support for SH hosting in orders and subs add create_configuration support for SH hosting in orders and subs Jan 28, 2025
@charcey charcey changed the title add create_configuration support for SH hosting in orders and subs WIP: add create_configuration support for SH hosting in orders and subs Jan 28, 2025
@charcey charcey changed the title WIP: add create_configuration support for SH hosting in orders and subs add "create configuration" support for SH hosting in orders and subs Jan 28, 2025
@charcey charcey merged commit 91a2593 into main Jan 28, 2025
9 checks passed
@charcey charcey deleted the cp/hosting-create-config branch January 28, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants