Skip to content

Conversation

ericrdunham
Copy link
Contributor

This pull request does 4 things:

  • Changes usage of the deprecated .isAlive from the threading library to .is_alive
  • Adds all item and asset types from the current staging environment to the supported default list, to prevent/limit calls to get_remote_choices
  • Makes the default timeout for _get_json_or_raise go to 11, as 0.7 was too short of a time to do an authenticated round-trip to the server and was triggering unhelpful user errors when attempting to query for non-local asset or item types
  • Mocks out calls in tests/test_types.py that would raise a 401 error when attempting to get remote item types or asset types, as these endpoints now require authentication

Copy link
Contributor

@sarasafavi sarasafavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ericrdunham !

@sarasafavi sarasafavi merged commit 6b250fb into master Jun 26, 2019
@sarasafavi sarasafavi deleted the eric.dunham/add-more-udm2-asset-types branch June 26, 2019 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants