filter cli command outputs a valid empty filter if all subfilters are removed. #654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… removed. document how to create this filter with api
|
@cholmes if this is a reasonable fix for 600, go ahead and approve and merge this. If not, comment with your thoughts and I'll address them when I get back. |
cholmes
approved these changes
Sep 7, 2022
|
Hey, apologies for not getting to this earlier. I approved the request, as I think it's a fine improvement, but don't see it as fully fixiing #600 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filter cli command outputs a valid empty filter if all subfilters are removed. document how to create this filter with the api.
closes #600