Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI should respect user‘s XDG base directory settings #429

Closed
yeskunall opened this issue Nov 26, 2021 · 0 comments · Fixed by #672
Closed

CLI should respect user‘s XDG base directory settings #429

yeskunall opened this issue Nov 26, 2021 · 0 comments · Fixed by #672

Comments

@yeskunall
Copy link

pscale shell creates a history file by default in $HOME/.pscale/history. While this is not an error, I think the CLI should respect an OS (or the user’s) XDG base directory settings. The history file should be placed under XDG_DATA_HOME: on Mac, it should go under ~/Library/Application \Support/.pscale and on most Unix-like operating systems, it should go under $HOME/.local/share.

I’d be happy to make a PR if you guys agree with the change.
mscoutermarsh added a commit that referenced this issue May 4, 2023
@mscoutermarsh
Respect users XDG directory setting for history file
323ce9e 
Closes: #429

This updates the CLI to use XDG_DATA_HOME for the location of the users history file.

The [xdg package](https://github.com/adrg/xdg) takes care of returning the path based on the operating system and creating the directory if it is not present.
@mscoutermarsh mscoutermarsh mentioned this issue May 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Respect users XDG directory setting for history file planetscale/cli
1 participant
@yeskunall