fix: prevent consumer crash when reading incomplete record batches #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mirza Brunjadze <brunjadzem@gmail.com>
mcollina
reviewed
Sep 12, 2025
|
Hello @ShogunPanda, unfortunately #116 didn't fix our issue. I'll try to create a small reproduction and open a new issue. |
|
Amazing. Let me know then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added batch buffer boundary checks to prevent crash on incomplete batch. Fixes #108.
I'm not sure if this is a proper fix, or maybe something needs to be adjusted in
connection.tsfor reader to not get incomplete batch in the first place.@ShogunPanda waiting for your feedback and I'll add/fix tests