Skip to content

Conversation

marklundin
Copy link
Member

This PR ensures that any engine property defined via a setter is called in the correct way. This was preventing internal values from updating

❌ before

collision.halfExtents.fromArray(value)

✅ Fix

collision.halfExtents = value

@marklundin marklundin self-assigned this Sep 24, 2025
Copy link

changeset-bot bot commented Sep 24, 2025

🦋 Changeset detected

Latest commit: dd92701

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@playcanvas/react Patch
@playcanvas/blocks Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Sep 24, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@playcanvas/blocks@259
npm i https://pkg.pr.new/@playcanvas/react@259

commit: dd92701

@marklundin marklundin requested a review from a team September 24, 2025 10:19
@marklundin marklundin merged commit 39c8647 into main Sep 24, 2025
7 checks passed
@marklundin marklundin deleted the fix-setter-assignment branch September 24, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants