Skip to content

Fix setter assignment #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2025
Merged

Fix setter assignment #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c61f71
Refactor validation utility to instantiate Vec2, Vec3, Vec4, and Quat…
marklundin Sep 24, 2025
dd92701
Add patch for @playcanvas/react to ensure proper invocation of member…
marklundin Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/easy-friends-wash.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@playcanvas/react": patch
---

Ensure any member defined with a setter is called appropriately
8 changes: 4 additions & 4 deletions packages/lib/src/utils/validation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ export function createComponentDefinition<T, InstanceType>(
errorMsg: (val) => `Invalid value for prop "${String(key)}": "${JSON.stringify(val)}". ` +
`Expected an array of 2 numbers.`,
apply: isDefinedWithSetter ? (instance, props, key) => {
(instance[key as keyof InstanceType] as Vec2).fromArray(props[key] as number[]);
(instance[key as keyof InstanceType] as Vec2) = new Vec2().fromArray(props[key] as number[]);
} : (instance, props, key) => {
(instance[key as keyof InstanceType] as Vec2).set(...props[key] as [number, number]);
}
Expand All @@ -391,7 +391,7 @@ export function createComponentDefinition<T, InstanceType>(
errorMsg: (val) => `Invalid value for prop "${String(key)}": "${JSON.stringify(val)}". ` +
`Expected an array of 3 numbers.`,
apply: isDefinedWithSetter ? (instance, props, key) => {
(instance[key as keyof InstanceType] as Vec3).fromArray(props[key] as number[]);
(instance[key as keyof InstanceType] as Vec3) = new Vec3().fromArray(props[key] as number[]);
} : (instance, props, key) => {
(instance[key as keyof InstanceType] as Vec3).set(...props[key] as [number, number, number]);
}
Expand All @@ -404,7 +404,7 @@ export function createComponentDefinition<T, InstanceType>(
default: [value.x, value.y, value.z, value.w],
errorMsg: (val) => `Invalid value for prop "${String(key)}": "${JSON.stringify(val)}". Expected an array of 4 numbers.`,
apply: isDefinedWithSetter ? (instance, props, key) => {
(instance[key as keyof InstanceType] as Vec4).fromArray(props[key] as number[]);
(instance[key as keyof InstanceType] as Vec4) = new Vec4().fromArray(props[key] as number[]);
} : (instance, props, key) => {
(instance[key as keyof InstanceType] as Vec4).set(...props[key] as [number, number, number, number]);
}
Expand All @@ -419,7 +419,7 @@ export function createComponentDefinition<T, InstanceType>(
errorMsg: (val) => `Invalid value for prop "${String(key)}": "${JSON.stringify(val)}". ` +
`Expected an array of 4 numbers.`,
apply: isDefinedWithSetter ? (instance, props, key) => {
(instance[key as keyof InstanceType] as Quat).fromArray(props[key] as number[]);
(instance[key as keyof InstanceType] as Quat) = new Quat().fromArray(props[key] as number[]);
} : (instance, props, key) => {
(instance[key as keyof InstanceType] as Quat).set(...props[key] as [number, number, number, number]);
}
Expand Down
Loading