Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try latest pip 22 and setuptools. #770

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Try latest pip 22 and setuptools. #770

merged 1 commit into from
Mar 9, 2022

Conversation

mauritsvanrees
Copy link
Member

I run into an error though:

Installing instance.
While:
  Installing instance.
  Getting distribution for 'pygments==2.11.2'.

An internal error occurred due to a bug in either zc.buildout or in a
recipe being used:
Traceback (most recent call last):
  File "/Users/maurits/community/plone-coredev/6.0/lib/python3.9/site-packages/zc/buildout/buildout.py", line 2250, in main
    getattr(buildout, command)(args)
  File "/Users/maurits/community/plone-coredev/6.0/lib/python3.9/site-packages/zc/buildout/buildout.py", line 855, in install
    installed_files = self[part]._call(recipe.install)
  File "/Users/maurits/community/plone-coredev/6.0/lib/python3.9/site-packages/zc/buildout/buildout.py", line 1651, in _call
    return f()
  File "/Users/maurits/shared-eggs/cp39/plone.recipe.zope2instance-6.10.2-py3.9.egg/plone/recipe/zope2instance/recipe.py", line 155, in install
    installed.extend(self.install_scripts())
  File "/Users/maurits/shared-eggs/cp39/plone.recipe.zope2instance-6.10.2-py3.9.egg/plone/recipe/zope2instance/recipe.py", line 949, in install_scripts
    requirements, ws = self.egg.working_set(["plone.recipe.zope2instance"])
  File "/Users/maurits/shared-eggs/cp39/zc.recipe.egg-2.0.7-py3.9.egg/zc/recipe/egg/egg.py", line 78, in working_set
    ws = self._working_set(
  File "/Users/maurits/shared-eggs/cp39/zc.recipe.egg-2.0.7-py3.9.egg/zc/recipe/egg/egg.py", line 161, in _working_set
    ws = zc.buildout.easy_install.install(
  File "/Users/maurits/community/plone-coredev/6.0/lib/python3.9/site-packages/zc/buildout/easy_install.py", line 965, in install
    return installer.install(specs, working_set)
  File "/Users/maurits/community/plone-coredev/6.0/lib/python3.9/site-packages/zc/buildout/easy_install.py", line 738, in install
    for dist in self._get_dist(req, ws):
  File "/Users/maurits/shared-eggs/cp39/plone.versioncheck-1.7.0-py3.9.egg/plone/versioncheck/tracking.py", line 24, in get_dist
    dists = old_get_dist(self, requirement, *ags, **kw)
  File "/Users/maurits/community/plone-coredev/6.0/lib/python3.9/site-packages/zc/buildout/easy_install.py", line 550, in _get_dist
    dist, avail = self._satisfied(requirement)
  File "/Users/maurits/community/plone-coredev/6.0/lib/python3.9/site-packages/zc/buildout/easy_install.py", line 346, in _satisfied
    return None, self._obtain(req, source)
  File "/Users/maurits/community/plone-coredev/6.0/lib/python3.9/site-packages/zc/buildout/easy_install.py", line 473, in _obtain
    if index.obtain(requirement) is None:
  File "/Users/maurits/community/plone-coredev/6.0/lib/python3.9/site-packages/setuptools/package_index.py", line 492, in obtain
    self.prescan()
  File "/Users/maurits/community/plone-coredev/6.0/lib/python3.9/site-packages/setuptools/package_index.py", line 534, in prescan
    list(map(self.scan_url, self.to_scan))
  File "/Users/maurits/community/plone-coredev/6.0/lib/python3.9/site-packages/setuptools/package_index.py", line 818, in scan_url
    self.process_url(url, True)
  File "/Users/maurits/community/plone-coredev/6.0/lib/python3.9/site-packages/zc/buildout/patches.py", line 120, in process_url
    plinks = list(parse_links(html_page))
TypeError: wrapper_wrapper() missing 1 required positional argument: 'use_deprecated_html5lib'

@mauritsvanrees
Copy link
Member Author

We have a zc.buildout 3.0.0rc2! This fixes the error above. I have rebased and we are using the very latest versions of everything again.

Next problem, see the actions:

2022-03-04T13:59:29.3666999Z While:
2022-03-04T13:59:29.3667214Z   Installing.
2022-03-04T13:59:29.3667440Z   Loading extensions.
2022-03-04T13:59:29.3667857Z   Getting distribution for 'plone.versioncheck==1.7.0'.
2022-03-04T13:59:29.3668077Z 
2022-03-04T13:59:29.3668263Z An internal error occurred due to a bug in either zc.buildout or in a
2022-03-04T13:59:29.3668581Z recipe being used:
2022-03-04T13:59:29.3668837Z Traceback (most recent call last):
2022-03-04T13:59:29.3678255Z   File "/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/zc/buildout/buildout.py", line 2250, in main
2022-03-04T13:59:29.3678770Z     getattr(buildout, command)(args)
2022-03-04T13:59:29.3679513Z   File "/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/zc/buildout/buildout.py", line 696, in install
2022-03-04T13:59:29.3679924Z     self._load_extensions()
2022-03-04T13:59:29.3680855Z   File "/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/zc/buildout/buildout.py", line 1235, in _load_extensions
2022-03-04T13:59:29.3681341Z     newest=self.newest, allow_hosts=self._allow_hosts)
2022-03-04T13:59:29.3681993Z   File "/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/zc/buildout/easy_install.py", line 971, in install
2022-03-04T13:59:29.3682446Z     return installer.install(specs, working_set)
2022-03-04T13:59:29.3683083Z   File "/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/zc/buildout/easy_install.py", line 696, in install
2022-03-04T13:59:29.3683617Z     for dist in self._get_dist(requirement, ws):
2022-03-04T13:59:29.3684258Z   File "/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/zc/buildout/easy_install.py", line 581, in _get_dist
2022-03-04T13:59:29.3684719Z     dists = [_move_to_eggs_dir_and_compile(dist, self._dest)]
2022-03-04T13:59:29.3685419Z   File "/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/zc/buildout/easy_install.py", line 1913, in _move_to_eggs_dir_and_compile
2022-03-04T13:59:29.3685869Z     unpacker(dist.location, tmp_dest)
2022-03-04T13:59:29.3686488Z   File "/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/zc/buildout/easy_install.py", line 1847, in unpack_wheel
2022-03-04T13:59:29.3686963Z     wheel.install_as_egg(os.path.join(dest, wheel.egg_name()))
2022-03-04T13:59:29.3687659Z   File "/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/setuptools/wheel.py", line 95, in install_as_egg
2022-03-04T13:59:29.3688101Z     self._install_as_egg(destination_eggdir, zf)
2022-03-04T13:59:29.3688731Z   File "/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/setuptools/wheel.py", line 103, in _install_as_egg
2022-03-04T13:59:29.3689186Z     self._convert_metadata(zf, destination_eggdir, dist_info, egg_info)
2022-03-04T13:59:29.3689862Z   File "/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/setuptools/wheel.py", line 164, in _convert_metadata
2022-03-04T13:59:29.3690360Z     setup_dist.get_command_obj('egg_info'),
2022-03-04T13:59:29.3691005Z   File "/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/setuptools/_distutils/dist.py", line 859, in get_command_obj
2022-03-04T13:59:29.3691459Z     cmd_obj = self.command_obj[command] = klass(self)
2022-03-04T13:59:29.3692059Z   File "/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/setuptools/__init__.py", line 174, in __init__
2022-03-04T13:59:29.3692444Z     super().__init__(dist)
2022-03-04T13:59:29.3693068Z   File "/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/setuptools/_distutils/cmd.py", line 57, in __init__
2022-03-04T13:59:29.3693565Z     raise TypeError("dist must be a Distribution instance")
2022-03-04T13:59:29.3693921Z TypeError: dist must be a Distribution instance

Some info about that on stackoverflow. It likely has nothing to do with plone.versioncheck.

Any idea?

The previous buildout rc gave an error with pip 22, but a fix was released today.

We cannot use setuptools 60 yet, as it gives an error with buildout 3:

    TypeError: dist must be a Distribution instance

See for example buildout/buildout#603 (comment)
@mauritsvanrees
Copy link
Member Author

@jenkins-plone-org please run jobs

@mauritsvanrees
Copy link
Member Author

Switched back to setuptools 59. Green!

@jensens jensens merged commit 42efcc2 into 6.0 Mar 9, 2022
@jensens jensens deleted the pip22 branch March 9, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants