-
-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring back "Guidelines for Contributing" #3644
Conversation
✅ Deploy Preview for volto ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Thanks for taking this on, @ksuess! For the record, the original file Review coming shortly. |
We now have a Plone GitHub organization I would suggest that we add a
More information about GitHub Community Health Files, specifically About contributing guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of obsolete stuff needed changing.
Feedback appreciated.
|
||
All text that can be shown in a browser must be translatable. Please mark all such | ||
strings as translatable as defined in the [i18n guide](../recipes/i18n.md) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace everything below this comment with the following.
## Code Quality
All pull requests must pass tests, documentation builds, and other code quality checks.
Contributors are strongly encouraged to run these checks locally before creating a pull request.
These checks are enforced automatically on every pull request, so you might as well save time and frustration by doing these checks locally first.
Specifically:
- {doc}`./linting`
- {doc}`./testing`
- {doc}`./acceptance-tests`
If after reading this you become hesitant, don't worry.
You can always create a pull request, mark it as "Draft", and improve the above points later, requesting help from the community.
Welcome to the Plone community, and thank you for contributing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM!
Co-authored-by: Steve Piercy <web@stevepiercy.com>
cbcb447
to
873dc2a
Compare
Thanks! |
#3643 (comment)