Build actual dash_bio node.js package in CI build.

[mkcor]

Closes #300.

About

We wanted to ensure that dash_bio/bundle.js builds successfully. This is now done, with the changes submitted here.

Description of changes

I've added command npm run build:js to the "node" job, which runs in a node.js environment.

Ultimately, we may want to address the following warning:

Before merging

• I have gone through the code review checklist
• I have completed all of the steps to take before merging
• I know how to deploy to DDS

[mkcor]

The Python classes are built via npm run build:py -- I wonder how/where we could run this command...

[shammamah-zz]

@VeraZab Is there anything that we can do about the size of the bundle? We're already using the minified code.

[shammamah-zz]

@mkcor npm run build:all runs build:js and build:py -- so that's the only one that we need to run :)

Misread the script name.

[mkcor]

@VeraZab Is there anything that we can do about the size of the bundle? We're already using the minified code.

Well, first we should study https://webpack.js.org/guides/code-splitting/ in depth--has any one of us already done so? I haven't.

[shammamah-zz]

Right, that makes sense. Is there a way to install the Python requirements before running the node job? Here

dash-bio/.circleci/config.yml

Line 95 in d5dadfe

workflows:

I'm seeing that you can define jobs and then run them in a specific order: https://circleci.com/docs/2.0/workflows/

So we can just create a new job in our CircleCI config that installs dash (that should be the only package used to build the Python components), and run that before we run npm run build:all.

[mkcor]

@mkcor npm run build:all runs build:js and build:py -- so that's the only one that we need to run :)

As is, we have separate node and python envs, so we can't run npm run build:js & npm run build:py at once.

Misread the script name.

When reviewing a PR, it's useful to look at the Commits tab, not just the diff (Files tab).

[mkcor]

@shammamah So we can just create a new job in our CircleCI config that installs dash

No, each job has its own docker image, as you can see. So if you want to use a dependency that was just installed (dash in our case), these two commands have to run within the same job.

I'm happy to install dash before running npm run build:py but I think we should keep the two commands (npm run build:js & npm run build:py) so the sequence is explicit.

[shammamah-zz]

Sure, I think that makes the most sense.

[mkcor]

@shammamah wait, I think it's really not straightforward to run Python code in this Node environment... We are now using a Docker image that's readily available:

dash-bio/.circleci/config.yml

Line 6 in c90e6b1

- image: circleci/node:11.10.1

We would need a different (custom, Python-equipped) one, should we run the following Python code:

import dash; dash.development.component_loader.generate_classes('dash_bio', 'dash_bio/metadata.json')

as done by npm run build:py:

dash-bio/dash_bio/package.json

Line 13 in c90e6b1

"build:py": "node ./extract-meta src/lib/components > dash_bio/metadata.json && copyfiles package.json dash_bio && python -c \"import dash; dash.development.component_loader.generate_classes('dash_bio', 'dash_bio/metadata.json')\"",

I'm hesitating between two options:

• creating a dedicated Docker image suitable for running npm run build:py;
• breaking down the various commands contained in npm run build:py (doable by resorting to store_artifacts).

Gets me thinking a lot about the node/python coupling...

[shammamah-zz]

creating a dedicated Docker image suitable for running npm run build:py;

I'd choose this, since it represents a well-defined "step" in our build process.

[VeraZab]

@mkcor @shammamah this looks like a reasonable change to me.
I feel like you guys know better at this point, since I haven't kept updated about the latest evolvements of the repo.

[mkcor]

I went for a Node.js variant Docker image, including our own specific version of Node.js / NPM as exemplified here: https://circleci.com/docs/2.0/circleci-images/#best-practices
This way, we can compile the components into Python right after building the Node.js package (9c9a4bd) and after installing dash (7d4a1a2).

[mkcor]

I thought caching the dash dependency wasn't worthwhile, hence 18010a7.

[mkcor]

Oh, and I probably need to cherry-pick this commit 1b32450 :)