Updated dependencies and PropTypes fix #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shammamah-zz
changed the title
|
I'm more than happy to approve, but I guess #312 should be merged first, for version numbers to make sense! |
|
@mkcor Latest changes from |
|
@shammamah do you mind approving #304 first? |
|
Then you'll have to update this branch against |
|
Thanks, @shammamah! Updated the branch and reviewing now. |
mkcor
approved these changes
Apr 11, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #313
About
Description of changes
molecule-3d-for-reactfork I made, I addressed React v15.5 update causes breaking changes Autodesk/molecule-3d-for-react#36 and it no longer gives us the error I was getting.Before merging