Skip to content

Speck component rendering fix #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 10, 2019
Merged

Speck component rendering fix #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c5695fa
Add callback to load structure immediately after renderer is defined.
Apr 9, 2019
5796859
Disable no-invalid-this error.
Apr 9, 2019
29c4cb1
Bump rc version in package.
Apr 9, 2019
d14208a
Regenerate bundle and package.
Apr 9, 2019
d82d5b8
Update version number in requirements.
Apr 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dash_bio/bundle.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dash_bio/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "dash-bio",
"version": "0.0.9-rc3",
"version": "0.0.9-rc4",
"description": "Dash components for bioinformatics",
"main": "build/index.js",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "dash-bio",
"version": "0.0.9-rc3",
"version": "0.0.9-rc4",
"description": "Dash components for bioinformatics",
"main": "build/index.js",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ biopython
colour==0.1.5
cython>=0.19
dash>=0.40.0
dash-bio==0.0.9-rc3
dash-bio==0.0.9-rc4
dash-daq==0.1.4
gunicorn
jsonschema
Expand Down
13 changes: 9 additions & 4 deletions src/lib/components/Speck.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,15 @@ export default class Speck extends Component {
const aoResolution = 300;
const renderer = new SpeckRenderer(canvas, resolution, aoResolution);

this.setState({
renderer: renderer,
refreshView: true,
});
this.setState(
{
renderer: renderer,
refreshView: true,
},
function() {
this.loadStructure(this.props.data); // eslint-disable-line no-invalid-this
}
);

// add event listeners
const interactionHandler = new SpeckInteractions( // eslint-disable-line no-unused-vars
Expand Down