Speck component rendering fix #311
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #310
About
Description of changes
This issue was due to the fact that
loadStructure
was not being called fromcomponentDidMount
, and instead only fromcomponentDidUpdate
. I also ran into an issue whereloadStructure
failed becausethis.state.renderer
was stillnull
, even after having defined it -- this was becausesetState
does not immediately mutate the state of the component (https://reactjs.org/docs/react-component.html#setstate). From the documentation:I therefore added a callback to call
loadStructure()
only after the renderer had been updated to a non-null value.Before merging