-
-
Notifications
You must be signed in to change notification settings - Fork 192
Update dashBio package for compatibility with dash 0.1.0 #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃 But with some small comments!
DESCRIPTION
Outdated
Depends: R (>= 3.0.2), manhattanly | ||
Imports: dash | ||
Suggests: | ||
Suggests: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this whitespace be here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can fix that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 26f0401.
- color (character; required): the color of the block. | ||
- label (character; required): the labels of the block. | ||
- id (character; required): the id of the block, where it will recieve | ||
data from the specified "track" id.s. The overall layout of the Circos graph, provided |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be better to have everything after/including "The overall layout..." before this list -- it kind of looks like it's part of the last element in the list, but it isn't. The extraneous s.
should be covered by my changes in plotly/dash#782, but those haven't been released yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this is a tricky one (but a very valid point). It's because the generator detects that layout
has PropTypes.exact
, and so it handles the nested typing. Because it's a typing argument, it's at the head of the string (as are all types).
I'm not entirely sure how we would break the typing string in half, and insert the The overall layout of the Circos graph, provided as a list of dictionaries. after ..., 'id'. but I can look into it for the next release. I'll open an issue in the dash
repo so I don't lose track of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback; noted in plotly/dash#799.
.Rbuildignore
Outdated
index.py | ||
config.py | ||
usage.py | ||
setup.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a regression... I remember reviewing this before, but I can't break the commits down because it looks like they were rebased into 28c375b.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noting this. Fixed in d7bd0d4.
.Rbuildignore
Outdated
.pylintrc | ||
test/ | ||
# CRAN has weird LICENSE requirements | ||
LICENSE.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, I remember reviewing this and @shammamah had fixed it accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in d7bd0d4.
…to update-for-dash-0.1.0
About
dash-bio
support in Dash for R.Description of changes
prop-types
Updated dependencies and PropTypes fix #314Before merging