Revise CI tests to have a more stable run #5602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - run: | ||
| name: Test plotly bundles against es6 | ||
| command: npm run no-es6-dist | ||
| - run: | ||
| name: Test plotly bundles againt duplicate keys | ||
| environment: | ||
| NODE_OPTIONS: --max_old_space_size=4096 |
There was a problem hiding this comment.
What was this option about, and why are we removing it?
There was a problem hiding this comment.
It used to be there as a hack to help the duplicate-key test run.
It is no longer needed.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past months, we encountered some issues when running our tests on the CI.
Namely
no-gl-jasminecontainer regularly failed due to not finding the test files.Also the
publish-disttake several minutes to complete.As a result it took several (or infinite) re-runs to get a green light.
This PR helps fix these problems by splitting tests.
@plotly/plotly_js