Skip to content

Revise CI tests to have a more stable run #5602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 21, 2021
Merged

Revise CI tests to have a more stable run #5602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1eaea1a
increase parallelism for jasmine tests part A and B
archmoj Apr 21, 2021
69efe3e
add a flaky tag
archmoj Apr 21, 2021
aa4bb2d
add one noci flag
archmoj Apr 21, 2021
2aabfd3
move dist tests to a separate containers and run in parallel
archmoj Apr 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 28 additions & 4 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
docker:
# need '-browsers' version to test in real (xvfb-wrapped) browsers
- image: circleci/node:12.13.0-browsers
parallelism: 2
parallelism: 8
working_directory: ~/plotly.js
steps:
- attach_workspace:
Expand All @@ -57,7 +57,7 @@ jobs:
docker:
# need '-browsers' version to test in real (xvfb-wrapped) browsers
- image: circleci/node:12.13.0-browsers
parallelism: 3
parallelism: 8
working_directory: ~/plotly.js
steps:
- attach_workspace:
Expand Down Expand Up @@ -170,6 +170,18 @@ jobs:
echo https://$CIRCLE_BUILD_NUM-$PROJECT_NUM-gh.circle-artifacts.com/0/dist/plotly.js
echo https://$CIRCLE_BUILD_NUM-$PROJECT_NUM-gh.circle-artifacts.com/0/dist/plotly.min.js
echo https://$CIRCLE_BUILD_NUM-$PROJECT_NUM-gh.circle-artifacts.com/0/dist/plot-schema.json
- persist_to_workspace:
root: ~/
paths:
- plotly.js

test-dist1:
docker:
- image: circleci/node:12.13.0
working_directory: ~/plotly.js
steps:
- attach_workspace:
at: ~/
- run:
name: Test validation using node.js and jsdom
command: npm run test-plain-obj
Expand All @@ -182,13 +194,19 @@ jobs:
- run:
name: Test certain bundles against function constructors
command: npm run no-new-func

test-dist2:
docker:
- image: circleci/node:12.13.0
working_directory: ~/plotly.js
steps:
- attach_workspace:
at: ~/
- run:
name: Test plotly bundles against es6
command: npm run no-es6-dist
- run:
name: Test plotly bundles againt duplicate keys
environment:
NODE_OPTIONS: --max_old_space_size=4096
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was this option about, and why are we removing it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It used to be there as a hack to help the duplicate-key test run.
It is no longer needed.

command: npm run no-dup-keys

workflows:
Expand Down Expand Up @@ -220,3 +238,9 @@ workflows:
- publish-dist:
requires:
- install-and-cibuild
- test-dist1:
requires:
- publish-dist
- test-dist2:
requires:
- publish-dist
2 changes: 1 addition & 1 deletion test/jasmine/tests/sankey_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1318,7 +1318,7 @@ describe('sankey tests', function() {
.then(done, done.fail);
});

it('should persist the position of every nodes after drag in attributes nodes.(x|y)', function(done) {
it('@flaky should persist the position of every nodes after drag in attributes nodes.(x|y)', function(done) {
mockCopy.data[0].arrangement = arrangement;
var move = [50, -50];
var nodes;
Expand Down
2 changes: 1 addition & 1 deletion test/jasmine/tests/splom_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1684,7 +1684,7 @@ describe('Test splom select:', function() {
.then(done, done.fail);
});

it('@gl should redraw splom traces before scattergl trace (if any)', function(done) {
it('@noci @gl should redraw splom traces before scattergl trace (if any)', function(done) {
var fig = require('@mocks/splom_with-cartesian.json');
fig.layout.dragmode = 'select';
fig.layout.width = 400;
Expand Down