Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hover on IE #6466

Merged
merged 3 commits into from
Feb 2, 2023
Merged

Fix hover on IE #6466

merged 3 commits into from
Feb 2, 2023

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Feb 2, 2023

Fix regression introduced in [v2.5.0](https://github.com/plotly/plotly.js/releases/tag/v2.5.0 by 388986b777. cc: #5916.

It appears the getBoundingClientRect method on IE does not return x and y!

Instead one should use left and top.

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable regression this used to work labels Feb 2, 2023
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 That's clearer usage anyway - x and y for a bounding box are ambiguous.

That said, I really don't want us spending more time on IE. I'd prefer we explicitly drop support for it (maybe the same way we did in Dash: remove 'es5' from the webpack config target and add "browserslist": ["last 7 years and not dead"] to package.json (which webpack picks up) so that we don't feel any need to test in IE ever again.

@alexcjohnson
Copy link
Collaborator

The fact that this bug has been present since v2.5 is a good indication that IE doesn't matter to our users.

@archmoj archmoj merged commit fb2e544 into master Feb 2, 2023
@archmoj archmoj deleted the fix-hover-IE branch February 2, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken regression this used to work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants