Skip to content

Fix hover on IE #6466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 2, 2023
Merged

Fix hover on IE #6466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f34a9ba
fix hover on IE - note getBoundingClientRect on IE has no x and y
archmoj Feb 2, 2023
eaad4f7
remove unnecessary checks for dom rects
archmoj Feb 2, 2023
a0c6ec0
log for PR 6466
archmoj Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions draftlogs/#6466_fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fix hover on IE (regression introduced in 2.5.0) [#6466](https://github.com/plotly/plotly.js/pull/6466)
4 changes: 2 additions & 2 deletions src/components/fx/hover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2124,8 +2124,8 @@ function getBoundingClientRect(gd, node) {

var rect = node.getBoundingClientRect();

var x0 = rect.x;
var y0 = rect.y;
var x0 = rect.left;
var y0 = rect.top;
var x1 = x0 + rect.width;
var y1 = y0 + rect.height;

Expand Down
2 changes: 0 additions & 2 deletions src/lib/dom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,6 @@ function isTransformableElement(element) {
function equalDomRects(a, b) {
return (
a && b &&
a.x === b.x &&
a.y === b.y &&
a.top === b.top &&
a.left === b.left &&
a.right === b.right &&
Expand Down