Skip to content

Commit f94c9ff

Browse files
committed
workaround for trace disappearing when all transforms are deleted
1 parent cab595d commit f94c9ff

File tree

3 files changed

+13
-6
lines changed

3 files changed

+13
-6
lines changed

src/EditorControls.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -232,10 +232,14 @@ class EditorControls extends Component {
232232
isNumeric(payload.transformIndex) &&
233233
payload.traceIndex < graphDiv.data.length
234234
) {
235-
graphDiv.data[payload.traceIndex].transforms.splice(
236-
payload.transformIndex,
237-
1
238-
);
235+
if (graphDiv.data[payload.traceIndex].transforms.length === 1) {
236+
delete graphDiv.data[payload.traceIndex].transforms;
237+
} else {
238+
graphDiv.data[payload.traceIndex].transforms.splice(
239+
payload.transformIndex,
240+
1
241+
);
242+
}
239243
if (this.props.onUpdate) {
240244
this.props.onUpdate(
241245
graphDiv.data.slice(),

src/components/containers/TransformAccordion.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ class TransformAccordion extends Component {
7676
transformIndex={i}
7777
name={`${
7878
transformTypes.filter(({type}) => type === tr.type)[0].label
79-
}${transformBy[i]}`}
79+
}${transformBy && transformBy[i]}`}
8080
canDelete={true}
8181
>
8282
{children}

src/default_panels/GraphTransformsPanel.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,10 @@ export class Aggregations extends Component {
2525
}
2626

2727
return aggregations
28-
.filter(aggr => aggr.target.match(/transforms\[\d*\]\./gi) === null)
28+
.filter(
29+
aggr =>
30+
aggr.target && aggr.target.match(/transforms\[\d*\]\./gi) === null
31+
)
2932
.map(({target}, i) => (
3033
<AggregationSection show key={i} aggregationIndex={i}>
3134
<Dropdown

0 commit comments

Comments
 (0)