-
-
Couldn't load subscription status.
- Fork 1.5k
[doc] Search improvements #6073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
No regression tested rules have been changed. (comment created at 2025-10-24 12:59:21+00:00 for 8b0adeb) |
|
The new layout is nice! Two (Chrome/Windows specific?) issues: when search is not active, there is an empty search box: For renamed rules this gives the same description for both the new and the deprecated one -- it might be useful to replace the description of deprecated rules with just the word "Deprecated.". Suggestion for the future: Simple Jekyll Search has a new maintainer and the new version seems to have some useful features (e.g. ignores word order, unless quotes are used) https://github.com/neilboyd/Simple-Jekyll-Search . |
89f8936 to
4c3019d
Compare
Thanks!
Yes, I thought/wanted to use "auto". I'm using Firefox, which seems to be different in this regards doesn't force scrollbars. Anyway, using
Good idea, I've added this. We might need to experiment a little bit with the presentation, but it's better now.
Thanks for the hint - yes. At some point, we should update... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scrollbar issues are fixed now.
- split rule names - disable fuzzy search - correctly escape search index - remove unused news.html and news_archive.html
- display title and summary - navigation with arrow keys up/down - keyboard shortcut "s" for search - display 20 search results with scrolling
- close search results when clicking somewhere
- extracts rule descriptions into frontmatter - use rule descriptions as summary for search result - remove exclude configuration from search as it is not excluding data from search.json by key, but by regexing the content... - remove escape_regex again
Move search index into an own js file, that is loaded via <script> and not fetched. This allows to open the documentation locally in a browser and still use the search functionality. Otherwise, you'd need to run a local webserver.
4c221c3 to
f111bb2
Compare

Describe the PR
Improves the integrated search in the documentation:
Old:

New:

Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)