[java] UnusedLocalVariable: fix false negatives in pattern matching #6124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbynek
changed the title
|
Compared to main: (comment created at 2025-10-10 21:33:37+00:00 for e6a0b66) |
zbynek
force-pushed
the
unused-pattern
branch
from
6d961cc to
0a397d3
Compare
zbynek
force-pushed
the
unused-pattern
branch
from
0a397d3 to
e6a0b66
Compare
oowekyala
reviewed
Oct 17, 2025
.../sourceforge/pmd/lang/java/ast/jdkversiontests/java21/ScopeOfPatternVariableDeclarations.txt
Show resolved
Hide resolved
oowekyala
approved these changes
Oct 19, 2025
oowekyala
added
the
a:false-negative
oowekyala
added a commit
that referenced
this pull request
Oct 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
The unused variable rule should also inspect patterns. With Java 22 enforce using
_where possible, with Java 21 accept named variables when the whole type pattern cannot be removed.Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)