Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed detection of system PHP binaries #67

Merged
merged 1 commit into from
Oct 31, 2016
Merged

Fixed detection of system PHP binaries #67

merged 1 commit into from
Oct 31, 2016

Conversation

tnytown
Copy link
Contributor

@tnytown tnytown commented Oct 30, 2016

No description provided.

SOF3
SOF3 approved these changes Oct 30, 2016
View reviewed changes
Copy link
Member

@SOF3 SOF3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Git Bash on Windows, working well.

@SOF3 SOF3 added Type: Fix Bug fix, typo fix, or any other fix Category: Other labels Oct 30, 2016
dktapps
dktapps approved these changes Oct 31, 2016
View reviewed changes
Copy link
Member

@dktapps dktapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other users have informed me that it is working well.

@edalzell edalzell mentioned this pull request Oct 31, 2016
Closed
@dktapps dktapps merged commit d1f5963 into pmmp:master Oct 31, 2016
@tnytown tnytown deleted the system_php branch October 31, 2016 23:20
@dktapps dktapps added Category: Core Related to internal functionality and removed Category: Other labels Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dktapps dktapps dktapps approved these changes

@SOF3 SOF3 SOF3 approved these changes

Assignees
No one assigned
Labels
Category: Core Related to internal functionality Type: Fix Bug fix, typo fix, or any other fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tnytown @dktapps @SOF3