Select: Add deselectOnSecondClick prop (#1385) #1648
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 97ea628:
|
|
if you drag it and let the button go - imo if it deselects that is a bug, no? it seems unintuitive and i would much prefer a bugfix in that case than an extra prop. |
|
Thank you for your work on this pull request! We’re marking this PR as stale to encourage a final push to bring it across the finish line. Any update, comment, or change to the PR will automatically remove the stale label so it stays active in our workflow. If you need any help, don’t hesitate to connect with us on Discord for feedback and support. This PR will close automatically soon if there’s no further activity, but we’re here to help if you’re interested in getting it merged. Thank you for your contribution! |
|
We’re closing this pull request to help manage our workload and focus on active contributions. We really appreciate the effort you put into this, and we’d be happy to revisit it anytime you’re ready. Please feel free to re-open this PR or reach out on Discord if you’d like to continue — our community is always here to support you. Thanks again for your contribution and for helping us stay organized! |
Why
If you combine with you will notice, that an Object is deselected after you stop dragging it. In some scenarios it's unintuitive that the object is deselected on the second click. What Added the deselectOnSecondClick prop (default: true) to Select, which allows to disable the deselect-on-second-click behavior.