fix: correct calcultation for trackRect is offscreen

[ddrdragon]

Why

When <View /> is non-fullscreen, the calculation of isOffscreen doesn't consider the position of left and top.

I made a demo here. You can see the bottom boxes disappear suddenly when you scrolling before it's not fully outside the canvas.

What

The checking should use the canvas bounding box rather than only width and height (it assumes position at top left corner from the screen).

Checklist

• Ready to be merged

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
drei	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 5, 2024 1:29am

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

[ddrdragon]

Test demo after fixed here.

[shalanah]

I'm also having issues with this recently.

I'm putting my View into a horizontal scrolling div way down the window (bottom: 0px) and it's always reading as offscreen.

This calculation doesn't account of the canvas top/bottom etc (trackRect.top > canvasSize.height)

[github-actions]

Thank you for your work on this pull request! We’re marking this PR as stale to encourage a final push to bring it across the finish line.

Any update, comment, or change to the PR will automatically remove the stale label so it stays active in our workflow.

If you need any help, don’t hesitate to connect with us on Discord for feedback and support. This PR will close automatically soon if there’s no further activity, but we’re here to help if you’re interested in getting it merged. Thank you for your contribution!

[shalanah]

I'll try to test this out since I had to link to a different View as well.