Skip to content

Conversation

0livare
Copy link

@0livare 0livare commented Jun 9, 2021

Why

#1560 fixed a small typescript issue, but that fix unfortunately appears to not be used when installing @react-spring/web@9.2.3.

I believe the reason for that is the dependency versions of the various @react-spring packages were not updated.

This is from my yarn.lock file:

"@react-spring/web@^9.2.3":
  version "9.2.3"
  resolved "https://registry.yarnpkg.com/@react-spring/web/-/web-9.2.3.tgz#b9037719b489863ca2ad39caaacff6d315bbaea8"
  integrity sha512-dWRcgVDbO2UI9I03n/HVmCx9tY++Na+RwRzkzXv3E53BcFsjvnWGArnpj+xE/XgXiaII3ep2RmUj5jyYoukqGg==
  dependencies:
    "@react-spring/animated" "~9.2.0"
    "@react-spring/core" "~9.2.0"
    "@react-spring/shared" "~9.2.0"
    "@react-spring/types" "~9.2.0"

What

I updated all of the @react-spring dependency versions from 9.2.0 to 9.2.3.

I'm not 100% certain what some of the packages like @react-spring/zdog or @react-spring/konva are, but it seems like all the version numbers are always kept consistent, and my yarn install after this change seemed to still work.

Checklist

  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 9, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6431c95:

Sandbox Source
spring-card Configuration
spring-goo-blobs Configuration
spring-flip-card Configuration
spring-slide Configuration
spring-draggable-list Configuration
spring-cards-stack Configuration
spring-viewpager Configuration
spring-simple-transition Configuration
spring-image-fade Configuration
spring-list-reordering Configuration

@joshuaellis
Copy link
Member

I dont think this is the solution to your issue, this is a patch. AFAIK ~ means it'll only ever install version in this pattern 0.0.X, therefore npm should try to install 9.2.3 of the library even though it says 9.2.0 see here. I would try remove @react-spring packages and reinstall them. This will update the yarn.lock I believe.

@sudkumar
Copy link
Contributor

I agree with @joeporpeglia. This should do it. In my case, I updated the version in my package.json and ran npm install.

@0livare 0livare closed this Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants