Skip to content

fix: remove accessing elem.ref in renderTransitions #2373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 27, 2025
Merged

fix: remove accessing elem.ref in renderTransitions #2373

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8d0ded8
fix: remove accessing elem.ref in renderTransitions for react v19
robertjarske May 21, 2025
71d07a2
add version check
robertjarske May 21, 2025
c88778c
revert package.json check in favor of React.version
robertjarske May 21, 2025
14363ad
improve readability and add conditional ref prop to element
robertjarske May 23, 2025
ba46159
remove faulty conditional
robertjarske May 23, 2025
3a62f3e
set props assignment to empty object if elem or elem.props is nullish
robertjarske May 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions packages/core/src/hooks/useTransition.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
// Return a `SpringRef` if a deps array was passed.
const ref = useMemo(
() => (propsFn || arguments.length == 3 ? SpringRef() : void 0),
[]

Check warning on line 94 in packages/core/src/hooks/useTransition.tsx

View workflow job for this annotation

GitHub Actions / Style Checks 

React Hook useMemo has a missing dependency: 'propsFn'. Either include it or remove the dependency array
)

// Every item has its own transition.
Expand Down Expand Up @@ -432,15 +432,17 @@
{transitions.map((t, i) => {
const { springs } = changes.get(t) || t.ctrl
const elem: any = render({ ...springs }, t.item, t, i)
return elem && elem.type ? (
<elem.type
{...elem.props}
key={is.str(t.key) || is.num(t.key) ? t.key : t.ctrl.id}
ref={elem.ref}
/>
) : (
elem
)

const key = is.str(t.key) || is.num(t.key) ? t.key : t.ctrl.id
const isLegacyReact = React.version < '19.0.0'

const props = elem?.props ?? {}

if (isLegacyReact) {
props.ref = elem.ref
}

return elem && elem.type ? <elem.type key={key} {...props} /> : elem
})}
</>
)
Expand Down
Loading