-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Prettier CI/CD, remove deprecated options #3260
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3380381:
|
- name: Check formatting | ||
run: yarn run format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optionally, this can be moved earlier: before or after "Check lint" step
node_modules/ | ||
.yarn/ | ||
*.gltf | ||
*.mdx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignored MDX files, because semi rule set to false
and it adds semicolons at the beginning of root-level JSX code.
For example, this:
import { PerspectiveCamera } from '@react-three/drei'
<Canvas>
<PerspectiveCamera makeDefault manual />
</Canvas>
gets replaced by this:
import { PerspectiveCamera } from '@react-three/drei'
;<Canvas>
<PerspectiveCamera makeDefault manual />
</Canvas>
What's changed