lostPointerCapture event cancels pinch gestures

[ds300]

Hello 👋🏼

At tldraw we use use-gesture for our canvas interactions. We recently noticed one situation where we use a long press on our canvas (the gesture target elem) to open a context menu. In iOS safari, this was firing a pointerdown event on the canvas and a pointerup event on the context menu. This left the PinchEngine in a broken state where it thought that the pointer was still down because it never received the pointerup event.

I noticed that you use the lostpointercapture event in the DragEngine to handle precisely this kind of situation, and it seems to work for the PinchEngine too. At least in our case.

I'd normally add tests for a PR like this, but I ran into problems with your test setup and it seems like a rabbit hole to figure out so I didn't add any tests yet. Please let me know if you'd like me to dig in and figure that out.

[changeset-bot]

🦋 Changeset detected

Latest commit: 70281d5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@use-gesture/core	Patch
@use-gesture/react	Patch
@use-gesture/vanilla	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 70281d5:

Sandbox	Source
pmndrs/use-gesture	Configuration
pmndrs/use-gesture	Configuration
pmndrs/use-gesture	Configuration
pmndrs/use-gesture	Configuration
pmndrs/use-gesture	Configuration
pmndrs/use-gesture	Configuration
pmndrs/use-gesture	Configuration
pmndrs/use-gesture	Configuration
pmndrs/use-gesture	Configuration
pmndrs/use-gesture	Configuration

[dbismut]

Hey @ds300 thanks a lot for the PR, I'm a huge fan of tldraw. I'll merge this tomorrow. Just curious if you ran into a similar issue with drag?

[dbismut]

@ds300 would you mind giving me access rights to the PR or running pnpm changeset and pass this as a patch change if you know how this works?

[ds300]

@dbismut done!

And no we don't use the drag gesture so we haven't seen any issues there.