Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): Adds skipSubscribe option to proxyWithHistory #227

Merged
merged 5 commits into from
Aug 29, 2021

Conversation

promontis
Copy link
Contributor

No description provided.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 28, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f1dbf5a:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for suggestion. I wanted proxyWithHistory to be fully customizable, but this part subscribe wasn't customizable.
Here're suggestions to cover your use case and more.
Please let me know if you have a better name for the second argument.

src/utils/proxyWithHistory.ts Outdated Show resolved Hide resolved
src/utils/proxyWithHistory.ts Show resolved Hide resolved
src/utils/proxyWithHistory.ts Outdated Show resolved Hide resolved
promontis and others added 3 commits August 29, 2021 01:16
Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com>
Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com>
Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com>
@promontis
Copy link
Contributor Author

@dai-shi really liked your suggestions! I think skipSubscribe is a better name, can't think of a better one.

@dai-shi dai-shi changed the title Adds autosave option to proxyWithHistory fix(utils): Adds skipSubscribe option to proxyWithHistory Aug 28, 2021
@dai-shi
Copy link
Member

dai-shi commented Aug 28, 2021

oops, would you please run prettier?

@promontis
Copy link
Contributor Author

@dai-shi done

@dai-shi dai-shi merged commit 2fb2847 into pmndrs:main Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants