Borland C++ 5.5.1/5.82 warnings

[vszakats]

Build configuration: -DPNG_NO_STDIO, -DUNICODE and disabled PNG_CONSOLE_IO_SUPPORTED, PNG_CONVERT_tIME_SUPPORTED

Warning W8004 png.c 724: 'pos' is assigned a value that is never used in function png_convert_to_rfc1123_buffer
Warning W8012 png.c 2279: Comparing signed and unsigned values in function png_compare_ICC_profile_with_sRGB
Warning W8004 png.c 3146: 'size' is assigned a value that is never used in function png_ascii_from_fixed
Warning W8008 pngmem.c 80: Condition is always true in function png_malloc_base
Warning W8004 pngpread.c 593: 'old_buffer' is assigned a value that is never used in function png_push_save_buffer
Warning W8012 pngrtran.c 4463: Comparing signed and unsigned values in function png_do_expand
Warning W8012 pngrtran.c 4481: Comparing signed and unsigned values in function png_do_expand
Warning W8004 pngrutil.c 673: 'text' is assigned a value that is never used in function png_decompress_chunk
Warning W8012 pngrutil.c 1820: Comparing signed and unsigned values in function png_handle_tRNS
Warning W8012 pngrutil.c 1983: Comparing signed and unsigned values in function png_handle_hIST
Warning W8004 pngset.c 676: 'new_iccp_name' is assigned a value that is never used in function png_set_iCCP
Warning W8008 pngset.c 1525: Condition is always false in function png_set_compression_buffer_size
Warning W8066 pngset.c 1527: Unreachable code in function png_set_compression_buffer_size
Warning W8084 pngtrans.c 707: Suggest parentheses to clarify precedence in function png_do_check_palette_indexes
Warning W8004 pngwtran.c 487: 'dp' is assigned a value that is never used in function png_do_write_invert_alpha
Warning W8004 pngwtran.c 449: 'dp' is assigned a value that is never used in function png_do_write_invert_alpha
Warning W8004 pngwtran.c 425: 'dp' is assigned a value that is never used in function png_do_write_invert_alpha

[glennrp]

Thanks for the report.

Glenn

On Wed, Apr 1, 2015 at 10:55 AM, Viktor Szakáts notifications@github.com
wrote:

Build configuration: -DPNG_NO_STDIO, -DUNICODE and disabled
PNG_CONSOLE_IO_SUPPORTED, PNG_CONVERT_tIME_SUPPORTED

Warning W8004 png.c 724: 'pos' is assigned a value that is never used in function png_convert_to_rfc1123_buffer
Warning W8012 png.c 2279: Comparing signed and unsigned values in function png_compare_ICC_profile_with_sRGB
Warning W8004 png.c 3146: 'size' is assigned a value that is never used in function png_ascii_from_fixed
Warning W8008 pngmem.c 80: Condition is always true in function png_malloc_base
Warning W8004 pngpread.c 593: 'old_buffer' is assigned a value that is never used in function png_push_save_buffer
Warning W8012 pngrtran.c 4463: Comparing signed and unsigned values in function png_do_expand
Warning W8012 pngrtran.c 4481: Comparing signed and unsigned values in function png_do_expand
Warning W8004 pngrutil.c 673: 'text' is assigned a value that is never used in function png_decompress_chunk
Warning W8012 pngrutil.c 1820: Comparing signed and unsigned values in function png_handle_tRNS
Warning W8012 pngrutil.c 1983: Comparing signed and unsigned values in function png_handle_hIST
Warning W8004 pngset.c 676: 'new_iccp_name' is assigned a value that is never used in function png_set_iCCP
Warning W8008 pngset.c 1525: Condition is always false in function png_set_compression_buffer_size
Warning W8066 pngset.c 1527: Unreachable code in function png_set_compression_buffer_size
Warning W8084 pngtrans.c 707: Suggest parentheses to clarify precedence in function png_do_check_palette_indexes
Warning W8004 pngwtran.c 487: 'dp' is assigned a value that is never used in function png_do_write_invert_alpha
Warning W8004 pngwtran.c 449: 'dp' is assigned a value that is never used in function png_do_write_invert_alpha
Warning W8004 pngwtran.c 425: 'dp' is assigned a value that is never used in function png_do_write_invert_alpha

—
Reply to this email directly or view it on GitHub
#4.

[vszakats]

Hello Glenn, you're welcome.

[vszakats]

An updated list after 1.6.18:

Warning W8004 ../../../png.c 724: 'pos' is assigned a value that is never used in function png_convert_to_rfc1123_buffer
Warning W8004 ../../../png.c 3147: 'size' is assigned a value that is never used in function png_ascii_from_fixed
Warning W8008 ../../../pngmem.c 83: Condition is always true in function png_malloc_base
Warning W8012 ../../../pngrutil.c 1821: Comparing signed and unsigned values in function png_handle_tRNS
Warning W8012 ../../../pngrutil.c 1985: Comparing signed and unsigned values in function png_handle_hIST
Warning W8008 ../../../pngset.c 1527: Condition is always false in function png_set_compression_buffer_size
Warning W8008 ../../../pngset.c 1527: Condition is always false in function png_set_compression_buffer_size
Warning W8066 ../../../pngset.c 1529: Unreachable code in function png_set_compression_buffer_size
Warning W8004 ../../../pngwutil.c 2654: 'mins' is assigned a value that is never used in function png_write_find_filter

[glennrp]

Thanks again. I'll take a look.

[glennrp]

Fix pushed to libpng16 branch. The warnings in pngmem.c and pngset.c are unavoidable, where we are testing for potential overflow, and there are comments to explain those.

[vszakats]

Thanks a lot @glennrp. No problem with those. If you think so we can close this Issue.

(disclaimer: I'm not actually using Borland C++, but it still has some (well: one) unique warning and it is a popular option in an OSS project I contribute to and where libpng is used. That's the reason I brought it up.)

[glennrp]

OK. But libpng-1.6.19 probably won't be out for a few months or more.

[vszakats]

Time is not an issue. Many thanks for you work on libpng!