Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--userconfig #40

Closed
brianreavis opened this issue Jan 30, 2016 · 9 comments
Closed

--userconfig #40

brianreavis opened this issue Jan 30, 2016 · 9 comments
Assignees

Comments

@brianreavis
Copy link

After digging, this behavior is already possible by just using --config instead of --userconfig because of this line of rc (used by registry-url). Should this difference be noted in the readme, or for the sake of parity should this be brought up as an issue on rc?

@rstacruz
Copy link
Member

neat, why not!

@rstacruz
Copy link
Member

wait, what's --userconfig?

from how I understand what you said, it means we can use pnpm install --config custom_npmrc, and is probably worth noting somehow. Did I understand you correctly?

@brianreavis
Copy link
Author

Yeah, --userconfig is just NPM's flag for explicitly setting a specific path to a npmrc file. I've been using it because I don't store it in a home directory. And right: pnpm install --config custom_npmrc should work the same way :) Haven't tested it... but yea! Should work. Was just wondering if this manager aims to be sort of 1:1, or if it's just best to note that --config is the way to do it with pnpm and move on.

The alternative is we open a PR on rc to support some some way of reading process.argv['user-config'] vs process.argv.config

@rstacruz
Copy link
Member

Was just wondering if this manager aims to be sort of 1:1

Not really, but maybe 95% there. With the store model pnpm is doing, there are likely some things that we can't do.

I'm happy with not supporting --userconfig when --config does just fine — there are more important npm flags to implement, really.

One way we can do that is simply to pass process.argv with --userconfig swapped out for --config (rc('npm', {}, argv))

@rstacruz
Copy link
Member

closing this for now... it seems it's not really that important.

if anyone disagrees and needs this option, just voice it out and let's consider it again by then.

@zkochan
Copy link
Member

zkochan commented Apr 4, 2017

I suggest to support the npm parameter to avoid confusion.

@zkochan zkochan reopened this Apr 4, 2017
@danielbayley
Copy link

danielbayley commented Apr 4, 2017

As mentioned in #695, pnpm should also respect $NPM_CONFIG_USERCONFIG as npm does.

zkochan added a commit that referenced this issue Apr 19, 2017
BREAKING CHANGE:

`rc` is not used to get configs.

BREAKING CHANGE:

`.pnpmrc` files are ignored

BREAKING CHANGE:

configs in json format are not supported

BREAKING CHANGE:

`--config` argument renamed to `--userconfig`

Close #696, Close #40
zkochan added a commit that referenced this issue Apr 19, 2017
BREAKING CHANGE:

`rc` is not used to get configs.

BREAKING CHANGE:

`.pnpmrc` files are ignored

BREAKING CHANGE:

configs in json format are not supported

BREAKING CHANGE:

`--config` argument renamed to `--userconfig`

Close #696, Close #40
zkochan added a commit that referenced this issue Apr 20, 2017
BREAKING CHANGE:

`rc` is not used to get configs.

BREAKING CHANGE:

`.pnpmrc` files are ignored

BREAKING CHANGE:

configs in json format are not supported

BREAKING CHANGE:

`--config` argument renamed to `--userconfig`

Close #696, Close #40
zkochan added a commit that referenced this issue Apr 20, 2017
BREAKING CHANGE:

`rc` is not used to get configs.

BREAKING CHANGE:

`.pnpmrc` files are ignored

BREAKING CHANGE:

configs in json format are not supported

BREAKING CHANGE:

`--config` argument renamed to `--userconfig`

Close #696, Close #40
@zkochan zkochan self-assigned this Apr 20, 2017
zkochan added a commit that referenced this issue Apr 20, 2017
BREAKING CHANGE:

`rc` is not used to get configs.

BREAKING CHANGE:

`.pnpmrc` files are ignored

BREAKING CHANGE:

configs in json format are not supported

BREAKING CHANGE:

`--config` argument renamed to `--userconfig`

Close #696, Close #40
zkochan added a commit that referenced this issue Apr 20, 2017
BREAKING CHANGE:

`rc` is not used to get configs.

BREAKING CHANGE:

`.pnpmrc` files are ignored

BREAKING CHANGE:

configs in json format are not supported

BREAKING CHANGE:

`--config` argument renamed to `--userconfig`

Close #696, Close #40
@rulatir
Copy link

rulatir commented Jan 25, 2023

I very much need support for $NPM_CONFIG_USERCONFIG, and all mentions of that variable in other issues point here. Please reopen.

@rulatir
Copy link

rulatir commented Jan 25, 2023

I just realized that neither --userconfig nor --config exists in v7, and any possibility to override the default config-finding logic was completely removed. Why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants