enh(ProcessRunner): does not detect launch errors #4482 #4483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
matejk
force-pushed
the
4482-process-runner-launch-err-detect
branch
from
278cd49
to
83162c6
Compare
…executed can't be found in the path.
|
@aleks-f, I think that the solution implemented in the pushed works properly on *nix platforms. I need to finalise some details for Windows. |
matejk
force-pushed
the
4482-process-runner-launch-err-detect
branch
6 times, most recently
from
a305c76
to
260f89c
Compare
…e file to be executed can't be found using absolutePath.
matejk
force-pushed
the
4482-process-runner-launch-err-detect
branch
from
260f89c
to
4714200
Compare
|
@aleks-f, can this be merged to main? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: detect properly if executable does not exist