Skip to content

Commit

Permalink
e2e.sh: avoid GOCACHE=off
Browse files Browse the repository at this point in the history
GOCACHE=off is too strong (prevents reusing binaries) and is going to
break when updating to Go 1.12.x. Better use the `-count=1` trick to
force a re-run of the
tests (golang/go#24573 (comment)).
  • Loading branch information
pohly committed Apr 15, 2019
1 parent 07733b6 commit e8500f2
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions hack/e2e.sh
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ runTestAPI()
local pid=$!
trap 'cleanup $pid $1' EXIT

GOCACHE=off go test -v ./hack/_apitest/api_test.go && \
GOCACHE=off go test -v ./hack/_embedded/embedded_test.go
go test -count=1 -v ./hack/_apitest/api_test.go && \
go test -count=1 -v ./hack/_embedded/embedded_test.go
)

runTestAPIWithCustomTargetPaths()
Expand All @@ -66,7 +66,7 @@ runTestAPIWithCustomTargetPaths()

# Running a specific test to verify that the custom target paths are called
# a deterministic number of times.
GOCACHE=off go test -v ./hack/_apitest2/api_test.go -ginkgo.focus="NodePublishVolume"
go test -count=1 -v ./hack/_apitest2/api_test.go -ginkgo.focus="NodePublishVolume"
)

runTestWithCustomTargetPaths()
Expand Down

0 comments on commit e8500f2

Please sign in to comment.