-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Remove meeting feature. #2410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Remove meeting feature. #2410
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,38 +1,27 @@ | ||
import ComposableArchitecture | ||
import SwiftUI | ||
|
||
struct MeetingReducer: Reducer { | ||
struct State: Equatable { | ||
let meeting: Meeting | ||
let standup: Standup | ||
} | ||
enum Action: Equatable {} | ||
func reduce(into state: inout State, action: Action) -> Effect<Action> { | ||
} | ||
} | ||
|
||
struct MeetingView: View { | ||
let store: StoreOf<MeetingReducer> | ||
let meeting: Meeting | ||
let standup: Standup | ||
|
||
var body: some View { | ||
WithViewStore(self.store, observe: { $0 }) { viewStore in | ||
ScrollView { | ||
VStack(alignment: .leading) { | ||
Divider() | ||
.padding(.bottom) | ||
Text("Attendees") | ||
.font(.headline) | ||
ForEach(viewStore.standup.attendees) { attendee in | ||
Text(attendee.name) | ||
} | ||
Text("Transcript") | ||
.font(.headline) | ||
.padding(.top) | ||
Text(viewStore.meeting.transcript) | ||
ScrollView { | ||
VStack(alignment: .leading) { | ||
Divider() | ||
.padding(.bottom) | ||
Text("Attendees") | ||
.font(.headline) | ||
ForEach(self.standup.attendees) { attendee in | ||
Text(attendee.name) | ||
} | ||
Text("Transcript") | ||
.font(.headline) | ||
.padding(.top) | ||
Text(self.meeting.transcript) | ||
} | ||
.navigationTitle(Text(viewStore.meeting.date, style: .date)) | ||
.padding() | ||
} | ||
.navigationTitle(Text(self.meeting.date, style: .date)) | ||
.padding() | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this just be
case meeting
? Is this case even necessary?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We wouldn't want to use
case meeting
because that represents that the meeting view has an action when it does not. Andcase meeting(Never)
can never actually be created, due to theNever
, and so it definitely can be omitted entirely. I've just left it to have symmetry with theState
, but it's not strictly necessary.