Dismiss should be called on child being passed in dismiss closure #310
Conversation
acosmicflamingo
changed the title
|
Aww, two failures :( |
acosmicflamingo
force-pushed
the
fix-dismissing-vc
branch
from
eed6fac to
6328ef1
Compare
acosmicflamingo
force-pushed
the
fix-dismissing-vc
branch
from
6328ef1 to
3e53a67
Compare
|
The failure was in the flaky Going to clean this PR up but it looks like the source of the issues was treating dismissing self as if it was dismissing what was presented. |
|
GAH; it re-introduced the problem in #309 |
|
Yay! The flaky test is what failed, and it does fix #309. @mbrandonw @stephencelis would you be willing to entertain the idea that the test suite contain UI testing? The problem I face with creating a test that catches #309 is that everything works as expected when controlling navigation programatically. There is a difference in execution of steps between programmatically dismissing a child view controller, and swiping down (or tapping the "Ok" button on an alert), and I think only UI testing can capture these corner cases. |
|
Hi @acosmicflamingo, as discussed here: #309 (comment) 4f3baae doesn't fix the crash issue, which I believe is a seperate bug to what this PR is addressing. Happy for this PR to be merged. |
Addresses #309.
The issue is that the dismiss closure being passed the controller to be dismissed, but the actual area where the dismissal occurs is using
selfinstead of the respective controller. At least, that's the theory...let's see if tests pass. I was able to at least fix the issue that was in #309 with it.