Fix for crash when dismissing UIViewControllers when building with Xcode 26 #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-UIAlertController cases that was present in 2.5.0, fixes crash when building with XCode 26
|
@acosmicflamingo - keen for your opinion on this |
3 tasks
|
Tested on:
|
|
Interesting...I wonder if this has an impact on TCA apps that display alerts via state navigation. I'm not by my keyboard so I can't verify. What a find! |
|
Have tried in my own TCA app, and the alerts and confirmation dialogs still seem to work as expected. The codepath for this shouldn't affect the 2.5.1 behavior. Would be great verify on another TCA code base though. |
|
Hmm, it's a bit hard to fully validate in TCA without this PR included as things keep getting dismissed: #310 @acosmicflamingo Maybe we should wait until your other PR is merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #313
This change re-instates the original thread-hop before nilling out dismiss closure that was present in 2.5.0, for the non-UIAlertController case.
See 2.5.0...2.5.1
This fixes the issue, but I don't really have any clarity on why. Some quirk with the Xcode 26 toolset.