Swift 4 #21
Merged
Swift 4 #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use NSAttributedStringKey in string attributes * Use String slicing subscript with the PartialRangeUpTo operator
houndci-bot
reviewed
Oct 30, 2017
Source/TokenField/ICToken.swift
Outdated
| NSBackgroundColorAttributeName: UIColor(red:0.14, green:0.38, blue:0.95, alpha:1) | ||
| var highlightedTextAttributes: [NSAttributedStringKey: NSObject] = [ | ||
| .foregroundColor: UIColor.white, | ||
| .backgroundColor: UIColor(red:0.14, green:0.38, blue:0.95, alpha:1) |
There was a problem hiding this comment.
Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
Source/TokenField/ICToken.swift
Outdated
| NSForegroundColorAttributeName: UIColor(red:0.14, green:0.38, blue:0.95, alpha:1), | ||
| NSBackgroundColorAttributeName: UIColor.clear | ||
| var normalTextAttributes: [NSAttributedStringKey: NSObject] = [ | ||
| .foregroundColor: UIColor(red:0.14, green:0.38, blue:0.95, alpha:1), |
There was a problem hiding this comment.
Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
Example/CustomizedTokenField.swift
Outdated
| NSForegroundColorAttributeName: UIColor(red:0.8, green:0.32, blue:0.24, alpha:1), | ||
| NSBackgroundColorAttributeName: UIColor.white, | ||
| NSFontAttributeName: UIFont.boldSystemFont(ofSize: 14) | ||
| .foregroundColor: UIColor(red:0.8, green:0.32, blue:0.24, alpha:1), |
There was a problem hiding this comment.
Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
bcylin
added a commit
to bcylin/ICInputAccessory
that referenced
this pull request
Jan 20, 2018
Merge branch 'feature/swift-4' into develop
dlackty
approved these changes
Jan 22, 2018
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSAttributedStringKeyin string attributessubstring(to:)with String slicing subscript using thePartialRangeUpTooperatorSwift 3 @objc Inferenceto Default